Skip to content

Allow specifying template and fragment via View::named() #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekid merged 1 commit into from
Nov 18, 2023
Merged

Allow specifying template and fragment via View::named() #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/php/web/frontend/View.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ private function __construct($template) {
/**
* Sets template to use
*
* @param string $template
* @param string $name
* @return self
*/
public static function named($template) {
public static function named($name) {
sscanf($name, "%[^#]#%[^\r]", $template, $fragment);
$self= new self($template);
$self->fragment= $fragment;
$self->headers['Content-Type']= 'text/html; charset='.\xp::ENCODING;
return $self;
}
Expand Down
7 changes: 7 additions & 0 deletions src/test/php/web/frontend/unittest/ViewTest.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ public function fragment() {
Assert::equals('inline', View::named('test')->fragment('inline')->fragment);
}

#[Test]
public function template_and_fragment_separated_with_hash() {
$view= View::named('test#inline');
Assert::equals('test', $view->template);
Assert::equals('inline', $view->fragment);
}

#[Test]
public function default_status() {
Assert::equals(200, View::named('test')->status);
Expand Down