Allow login flows to return Continuation instances #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will rewrite the request URI and pass an "auth" value with the response, and then continue processing the request. This can be used e.g. to show a login page
thekid
commented
Nov 21, 2022
| // order to fulfill its job. | ||
| $result= $this->flow->authenticate($req, $res, $session); | ||
| if (null === $result) { | ||
| return; |
There was a problem hiding this comment.
Instead of redirection implemented in the Flow class, this could be also refactored to if ($result instanceof Redirect) { ... } and then handling that here. This would further simplify the implementations IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will rewrite the request URI and pass an "auth" value with the response, and then continue processing the request. This can be used e.g. to show a login page.