Skip to content

Updated disabled to use ngDisabled #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
m0to wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated disabled to use ngDisabled #46

m0to wants to merge 1 commit into from

Conversation

@m0to
Copy link

@m0to m0to commented Jul 29, 2016

Updated so its possible to set the disabled state externally.

gpcaretti
gpcaretti suggested changes Mar 22, 2017
View reviewed changes
Copy link

@gpcaretti gpcaretti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be coherent, you'd change line 12 as well by using attrs.ngDisabled.

IMHO a good general enhancement to your new code is to use: (attrs.ngDisabled || attrs.disabled) both in line 12 and 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gpcaretti gpcaretti gpcaretti requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m0to @gpcaretti