Fix beacon shell session cache concurrency and reuse #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Nicenonecb wants to merge 1 commit into xpipe-io:master from Nicenonecb:master

Nicenonecb commented Jan 9, 2026

What

Make beacon shell session cache concurrent and single-creation
Avoid double-starting shell controls
Reuse AppBeaconCache in ShellStartExchangeImpl and simplify stop logic

Why

Prevent duplicate shell session creation under concurrent requests
Avoid redundant start() calls on existing sessions
Improve stability for MCP/HTTP access paths

Changes

Use ConcurrentHashMap + computeIfAbsent keyed by entry UUID
Initialize control once (setNonInteractive + start) in cache creation path
ShellStartExchangeImpl now reuses AppBeaconCache.getOrStart
ShellStopExchangeImpl removes by UUID

Testing

Not run (requires local XPipe installation + JDK 25)


          Fix beacon shell session cache concurrency and reuse

1ef98c8

Member

crschnick commented Jan 9, 2026

Thanks for the PR, I will look into it when I find some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet