Skip to content

fix ResourceWarning: unclosed database #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Jun 28, 2025

Closes #32

@newville
Copy link
Member

@woutdenolf Thanks - that looks good to me. I am sort of curious if this can happen with the creation of the main "engine connection" in XrayDB. I wonder if we should add an atexit.register() to run XrayDB.close() when the process ends.

But, if this fixes the immediate issue, l'll merge.

@newville newville merged commit dfc8783 into xraypy:master Jun 29, 2025
4 checks passed
Copy link
Contributor

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite3 unclosed connection warning (python 3.13)
3 participants