XEP-0353/JMI: Fix specification and xml schema inconsistencies #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead import <reason/> element from Jingle namespace, so the XML schema matches with the examples.
To be consistent with the XML schema (which has minOccurs=maxOccurs=1).
github-actions
bot
added
the
Needs Author
lnjX
force-pushed
the
xep-0353/reference-jingle-reason
branch
from
dd4f845 to
94d02fa
Compare
lnjX
force-pushed
the
xep-0353/reference-jingle-reason
branch
from
94d02fa to
63c1711
Compare
|
Ping @tmolitor-stud-tu :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the schema says some elements MUST contain a '<reason/>' from
urn:xmpp:jingle-message:0and the examples and specification text said that some elements SHOULD contain a<reason/>element fromurn:xmpp:jingle:1.This does:
urn:xmpp:jingle:1in both XML schema and examples