Skip to content

Conversation

@wiegell
Copy link
Contributor

@wiegell wiegell commented Aug 1, 2025

WIP

PR Details

Fixes #99

Description

Trims before setting the name on elements

Related Issue

#99

Motivation and Context

We have such an .xsd at work

How Has This Been Tested

Added unit tests (sorry i'm only aware after i have made the tests, that you have an external test repo too, hope it's fine with these internal tests).

I am not strong in C and Rust, would appreciate if you look again if that code is correctly generated.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wiegell wiegell marked this pull request as draft August 1, 2025 09:04
@wiegell wiegell changed the title 99 trim ns from ref Fixes #99: trim ns from ref Aug 1, 2025
@wiegell wiegell marked this pull request as ready for review August 1, 2025 09:17
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants