Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove "volar.usePrettier" command and docs adjustment #122

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

yaegassy
Copy link
Owner

Description

The default value of prettier.disableLanguages has been changed in coc-prettier since "v9.2.0". Previously, vue was set to disable by default.

Because of this, if coc-prettier is installed, the built-in formatter of the Language Server (e.g. volar) will not be used, and prettier will be used preferentially.

For this reason, the volar.usePrettier command is unnecessary and has been removed.

If you want to use volar's built-in formatter

Added explanation to README.

@yaegassy yaegassy merged commit a6b87c7 into master Feb 24, 2022
@yaegassy
Copy link
Owner Author

yaegassy commented Feb 24, 2022

The example of setting prettier.formatterPriority to -1 doesn't look so good...

For example, in the case of html files, prettier is not used and the coc-html (html-language-features) formatter is used. I think it would be better to disable prettier only for vue in the vue project.

It is better to change the README description to only prettier.disableLanguages description.

@yaegassy yaegassy deleted the refactor/remove-use-prettier-command branch February 24, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant