Move Include to package-info #1852
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcekan
force-pushed
the
package-info-4x
branch
from
4430d96 to
c4b29bf
Compare
aklish
requested changes
Feb 22, 2021
| Collections.synchronizedMap(new LinkedHashMap<>()))); | ||
| } | ||
|
|
||
| for (Package beanPackage : beanPackages) { |
There was a problem hiding this comment.
What's the purpose of the second scan? The classpath scans are pretty expensive (they take multiple seconds). This could slow down the build quite a bit.
aklish
reviewed
Mar 12, 2021
elide-core/src/main/java/com/yahoo/elide/core/EntityBinding.java
Outdated
Show resolved
Hide resolved
aklish
reviewed
Mar 12, 2021
| relationshipsDeque.push(fieldName); | ||
| fieldsToValues.put(fieldName, fieldOrMethod); | ||
| fieldsToTypes.put(fieldName, fieldType); | ||
| fieldsToTypes.put(fieldName, fieldType == null ? Void.class : fieldType); |
There was a problem hiding this comment.
I get a NPE running with MappedSuperclass which returns fieldType as null. fieldsToTypes map does not accept null as a value.
There was a problem hiding this comment.
Is it probably the generics that causes the null fieldType.
There was a problem hiding this comment.
That is exactly the problem. RawType of type T is null.
added 2 commits
March 17, 2021 21:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the example bean to move Include annotation into package-info. This will verify we locate the annotation correctly in package-info there is none on the bean.
Motivation and Context
Elide 5.x had an issue due to a migration bug and adding test to 4.x to make sure it is tested.
How Has This Been Tested?
Unit testing.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.