-
-
Notifications
You must be signed in to change notification settings - Fork 659
Fix brace expansion and whitespace in CLI pattern options #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brace expansion and whitespace in CLI pattern options #469
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 85.07% 85.17% +0.09%
==========================================
Files 87 88 +1
Lines 4323 4350 +27
Branches 848 857 +9
==========================================
+ Hits 3678 3705 +27
Misses 645 645 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @yamadashy PR for fixing #467 |
Hey @yamadashy please look into this once available |
@pranshugupta01 The pattern parsing functionality works excellently. Since curly braces The code is now working as expected, so I'll go ahead and merge this PR! Thank you so much for your contribution! |
Issue
The CLI --include and --ignore options had two issues with pattern handling:
Solution
Before :
After :
Checklist
npm run test
npm run lint