Use git reset instead of git pull to avoid attempting a merge commit#8595
Open
andersk wants to merge 1 commit intoyarnpkg:masterfrom
Open
Use git reset instead of git pull to avoid attempting a merge commit#8595andersk wants to merge 1 commit intoyarnpkg:masterfrom
andersk wants to merge 1 commit intoyarnpkg:masterfrom
Conversation
Also, use git remote set-head in case the repository’s default branch has been renamed. Fixes yarnpkg#5303. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
git resetinstead ofgit pullto avoid attempting a merge commit. Also, usegit remote set-headin case the repository’s default branch has been renamed.Fixes #5303.
Test plan
Tested with this reproduction script:
Without this fix, the second
yarn addfails with:Even if one provides the requested Git configuration first, it still fails:
With this fix, it works correctly with or without the Git configuration: