Fix infinite loop when hoisting cyclic dependencies#8979
Open
yungsters wants to merge 1 commit intoyarnpkg:masterfrom
Open
Fix infinite loop when hoisting cyclic dependencies#8979yungsters wants to merge 1 commit intoyarnpkg:masterfrom
yungsters wants to merge 1 commit intoyarnpkg:masterfrom
Conversation
Comment on lines
+216
to
+218
| if (parent != null && parent.previousPatterns.has(pattern)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (parent != null && parent.previousPatterns.has(pattern)) { | |
| return null; | |
| } | |
| if (parent?.previousPatterns?.has(pattern)) { | |
| return null; | |
| } |
| const parts = parentParts.concat(pkg.name); | ||
| const key: string = this.implodeKey(parts); | ||
| const info: HoistManifest = new HoistManifest(key, parts, pkg, loc, isDirectRequire, isRequired, isIncompatible); | ||
| info.previousPatterns = new Set(parent == null ? [] : parent.previousPatterns).add(pattern); |
There was a problem hiding this comment.
Set constructor works fine if the argument is undefined. It will create an empty Set, so we can skip this validation.
Suggested change
| info.previousPatterns = new Set(parent == null ? [] : parent.previousPatterns).add(pattern); | |
| info.previousPatterns = new Set(parent?.previousPatterns).add(pattern); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that causes
yarnto infinite loop (and subsequently fail by running out of memory).This makes
yarn add @bluejay/[email protected]succeed, a cyclic dependency that currently breaksyarnand was originally reported in #6279.Test Plan
Verified this now succeeds: