-
Notifications
You must be signed in to change notification settings - Fork 0
Feature implementation from commits 89f29cb..b932e53 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature-base-1
Are you sure you want to change the base?
Conversation
* feat: redact credentials in remote urls * chore: improve function naming * fix: TaskfileNotSecureError should use redacted URI * feat: unexport all node implementation fields * fix: unexport HTTPNode.url
As recommended by the Event.Op godoc. Op is a bitmask, and some systems may send multiple operations at once
| } | ||
|
|
||
| return nil, errors.TaskfileNotFoundError{URI: u.String(), Walk: false} | ||
| return nil, errors.TaskfileNotFoundError{URI: u.Redacted(), Walk: false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security Issue
Security: URL Redaction for Error Messages.
Using u.Redacted() instead of u.String() prevents sensitive information in URLs from being exposed in error messages, which is a critical security improvement.
| case event, ok := <-eventsChan: | ||
| switch { | ||
| case !ok: | ||
| if !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡ Performance Issue
Removed Chmod Event Filtering.
The code no longer ignores chmod events, which will cause unnecessary processing when only file permissions change.
Current Code (Diff):
- if !ok {
- cancel()
- return
- }
+ switch {
+ case !ok:
+ cancel()
+ return
+ case event.Op == fsnotify.Chmod:
+ continue
+ }📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
| if !ok { | |
| switch { | |
| case !ok: | |
| cancel() | |
| return | |
| case event.Op == fsnotify.Chmod: | |
| continue | |
| } |
This PR contains changes from a range of commits from the original repository.
Commit Range:
89f29cb..b932e53Files Changed: 40 (21 programming files)
Programming Ratio: 52.5%
Commits included:
... and 5 more commits