forked from desktop/desktop
-
Notifications
You must be signed in to change notification settings - Fork 0
I tried made a multilingual platform for GitHub Desktop
Yasuhiro, Kaneko edited this page Oct 7, 2022
·
4 revisions
I tried made a multilingual platform
- The language part is shared by cli and render
- In the current structure, there is no choice but to embed the language and build it without extracting the language file as a separate file.
- There are more than 150 modified files this time, and there is too much modification risk to respond at once.
- LocalStorage cannot be used because the source is shared between cli and render
- Windows 10
- macOS Monterey (x64)
- Version 3.0.8
- For Windows(Windows 10)
- For Mac(intel, Monterey)
- i18next
- i18next-parser
- If there is an environment variable "GITHUB_DESKTOP_LANG", set it to that language
- If not, get the language with "Intl.NumberFormat().resolvedOptions().locale"
- Set to "en" if not in the judgment table
- Only Japanese has been translated
- Error messages are caught by jest, so they are not translatable.
- Date check format in test, so the multilingual part is passed with US setting
- Procedures for creating multilingual translation documents have not been created.