forked from ara818/django-autocompleter
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update_all method #41
Open
aropie
wants to merge
10
commits into
master
Choose a base branch
from
ac-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13312062270Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, the only way for changes to be reflected in the Autocompleter is to
remove_all
, thenstore_all
andremove_cache
. This makes for a slow and inefficient process because most of the objects weren't really updated.This PR introduces the method
update_all
, which in turn callsupdate_provider
for each of the Autocompleter's provider. This method aims to significantly reduce the number of operations made on Redis by bulking them together as much as possible, as well as analyze the data in order to only deal with objects which were actually modified, leaving the rest untouched.In order to do this, one of the main points was to add a new Redis hashmap
djac.provider.sc
which stores a mapping of obj_id -> score. This is done in order to have a reference to know when a given object has updated its score, since all objects use the same score across all the ranked sets.I've tried documenting the method and the reasoning as much as possible, but I agree the whole implementation still feels bulky and somewhat convoluted. Any suggestions on making it leaner/more concise are very welcome
How to test