-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken link for doc for great_expectations.md #1664
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rugk ,
thank you for your contribution. Nevertheless your commit messages do not comply with the expected format (eg feat: (description) or fix: (description)).
Please to contribute to our package make sure that you comply with that naming and convention. For now I've forced the change.
Ah I thought the format you've followed was https://www.conventionalcommits.org/, which is why I instinctively used Unfortunately, that requirement is also not written on https://github.com/ydataai/ydata-profiling/blob/develop/CONTRIBUTING.md only can only see it when it's too late aka when a PR/commit is made… (in the CI or so) Okay the CI still says:
But not which one? And thanks for fixing BTW, AFAIK you can also squash the commit when merging and get to enter a different commit message then. |
I know it's deprecated (which is also a little bit too subtle to be documented IMHO), but the link should work, at least.
Okay maybe it was the line length… anyway, it's a bit frustrating for me to guess what the CI actually wants from me… (Edit: ah and now the CI does not run because of that GitHub workflow approval ha, oh well… I hope it is fine for you now.) |
I know it's deprecated (which is also a little bit too subtle to be documented IMHO), but the link should work, at least.