Skip to content

[Filestore] cleanup service_ut_sharding.cpp test #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Filestore] cleanup service_ut_sharding.cpp test #3237

wants to merge 1 commit into from
+91 −347

Conversation

debnatkh
Copy link
Collaborator

FIxing this TODO:

nbs/cloud/filestore/libs/storage/service/service_ut_sharding.cpp

Lines 155 to 157 in e8e991c

// This function mocks the behavior of the TCreateFileStoreActor
// TODO(debnatkh): use single service.CreateFileStore request with
// AutomaticShardCreationEnabled

@debnatkh debnatkh added the filestore Add this label to run only cloud/filestore build and tests on PR label Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 15c9ad0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2126 2126 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilyTiger WilyTiger WilyTiger approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
filestore Add this label to run only cloud/filestore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debnatkh @WilyTiger