Added a new sdk method DescribeSystemView and a corresponded Grpc service #20603
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
n00bcracker
force-pushed
the
support_sysview_cpp_sdk
branch
from
15434ee to
16def4c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
n00bcracker
force-pushed
the
support_sysview_cpp_sdk
branch
2 times, most recently
from
48308d9 to
b78a9db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
n00bcracker
force-pushed
the
support_sysview_cpp_sdk
branch
from
b78a9db to
44a655a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
n00bcracker
force-pushed
the
support_sysview_cpp_sdk
branch
from
44a655a to
d406f44
Compare
n00bcracker
force-pushed
the
support_sysview_cpp_sdk
branch
from
d406f44 to
8342825
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -1806,6 +1811,9 @@ class TSession { | |||
| TAsyncDescribeExternalTableResult DescribeExternalTable(const std::string& path, | |||
| const TDescribeExternalTableSettings& settings = {}); | |||
|
|
|||
| TAsyncDescribeSystemViewResult DescribeSystemView(const std::string& path, | |||
There was a problem hiding this comment.
А почему это метод на сессии? Ему же Session Id не нужен.
There was a problem hiding this comment.
DescribeExternalTable тоже не использует SessionId, сделал по аналогии.
Подскажи, а куда тогда поместить этот метод?
There was a problem hiding this comment.
Хм, тогда и там значит неправильно сделано. С моей точки зрения, все такие методы должны быть на клиенте а не на сессии. Хотя ради консистентости можно и так оставить
Added dedicated method to describe system views via cpp sdk.
Before these changes describing system views was as describing table, but many options and attributes related to ordinal tables were inaccessible for system view, so DescribeTable method was redundant.