Skip to content

drop remote blacklist support #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

drop remote blacklist support #881

merged 1 commit into from
Apr 11, 2025

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 8, 2025

Remote blacklist url is 404.

Drop in favor of local blacklist.

Fixes #883

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Is there anything you'd like reviewers to focus on?

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice syntax cleanup too 🙂

@@ -0,0 +1,3 @@
const denyList = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Do we know what was previously served, and should that data go here? Is it https://github.com/yeoman/yeoman-generator-list/blob/3536bf0c8f0ba47b28a1f00bf8850982108c16b4/src/blacklist.js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.

@mshima mshima merged commit 29e2697 into yeoman:main Apr 11, 2025
11 checks passed
@mshima mshima deleted the blacklist branch April 11, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop remote blacklist support.
2 participants