Update mongoDB backend mongoDB driver interface #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was deprecated since Mongo Server 3.7.4. Its presence in queries produce failures in the mongoDB driver when interfacing against Mongo Servers >= version 6.0.
Replace the mongo driver's delete calls with deleteMany to restore correct behavior with Mongo 6.0 while preserving compatibility with Mongo 5.0.
Replace the mongo driver's modify(update) calls with updateMany to restore correct behavior in Mongo 6.0 and above. The key change here is that the writeConcern is now back to being set based on environment context rather than being hardcoded to "0".
parsonsmatt
reviewed
Aug 29, 2024
Match the current stack snapshot at version 2.7.1.2.
|
Hm, incompatible with GHC 8.4.4 because of We can do a follow-up PR to tighten our own base bounds and see what things we can adopt with 8.8 as our oldest compiler target. |
Co-authored-by: Matt Parsons <[email protected]>
|
OK, changes look good to me! Please add a changelog entry and a version bump for |
parsonsmatt
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mongoDB driver library introduced breaking changes to the current API calls used in persistent when interfacing with a mongoDB Server version 6.0 and above. Two of those changes, namely the change in behavior of the delete and update functions, seem irrational to me, but regardless they're already officially incorporated.
This PR makes the necessary changes to restore expected functionality whilst remaining backwards compatible with previous mongoDB versions, namely MongoDB 5.0, the EOL for which comes up this October. As alluded to, these changes were prompted for the mongoDB upgrade effort at work.
The mongo driver package itself needs a little more work to conform the server spec changes brought along with the Mongo Wire version 17, however, that is independent of these changes.