-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: batcher should not be able to build batches too big #1410
Merged
MauroToscano
merged 7 commits into
staging
from
1381-feat-batcher-should-not-be-able-to-build-batches-too-big
Nov 19, 2024
Merged
feat: batcher should not be able to build batches too big #1410
MauroToscano
merged 7 commits into
staging
from
1381-feat-batcher-should-not-be-able-to-build-batches-too-big
Nov 19, 2024
+151
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
MarcosNicolau
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked on macos and linux.
Oppen
reviewed
Nov 14, 2024
Oppen
reviewed
Nov 14, 2024
Oppen
approved these changes
Nov 14, 2024
MauroToscano
approved these changes
Nov 19, 2024
MauroToscano
approved these changes
Nov 19, 2024
MauroToscano
deleted the
1381-feat-batcher-should-not-be-able-to-build-batches-too-big
branch
November 19, 2024 16:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batcher max_batch_len limit
Description
This PR adds a feature on the Batcher that prevents it from making batches too big, that would revert in ETH due to gas cost limitations.
Type of change
Checklist
testnet
, everything else tostaging
To Test
You can play around with this new
max_batch_len
variable, set inconfig-batcher.yaml
.For example, set it at 16, then send a burst of 20.
You should see the batcher correctly sending one batch of 16 and another of 4.