fix: send aggregated response bump #1440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SendAggregatedResponse` would overwrite `tx`, which in the error case sets it to `nil`, causing the retry to dereference `nil`. This fix consists on using separate variables for the simulated tx and the real one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
WIP
TODO:
make the retry of
RespondToTaskV2, check if the merkle root was verified (via a cast call directly to the contract)and not wait for the tx receipt because receipt is not reliable and inserts a delay that breaks stuff
TITLE
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging