Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil dereference on aggregator retries #1441

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

fix: nil dereference on aggregator retries #1441

wants to merge 3 commits into from

Conversation

Oppen
Copy link
Collaborator

@Oppen Oppen commented Nov 19, 2024

fix: nil dereference on aggregator

SendAggregatedResponse would overwrite tx, which in the error case
sets it to nil, causing the retry to dereference nil.

This fix consists on using separate variables for the simulated tx and
the real one.

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@Oppen
fix: nil dereference on aggregator retries
545c003 
`SendAggregatedResponse` would overwrite `tx`, which in the error case
sets it to `nil`, causing the retry to dereference `nil`.

This fix consists on using separate variables for the simulated tx and
the real one.
Oppen
Oppen commented Nov 19, 2024
View reviewed changes
core/chainio/avs_writer.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

@uri-99 uri-99 uri-99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oppen @uri-99 @MarcosNicolau