Optimize showing hints in visual mode #2416
Open
+55
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent redundant recreation of the virtual text hint for selection shortcuts by checking if an existing extmark is already in the correct position. This avoids unnecessary API calls and improves performance.
Triggering autocommands on CursorMove event is pretty expensive, especially if they are not buffer-local, as they are triggered very often. Additionally the command itself is more expensive as it has to test whether it was triggered for the right buffer and right mode. Refactor the visual mode autocommands to be created for particular buffer when entering visual mode, and cleaned up upon exiting visual mode: - there is only global "ModeChanged" autocommand that triggers when entering visual mode - a new autocommand group is created when entering visual mode and "CursorMoved", second "ModeChanged", and "BufLeave" autocommands are made buffer-local and moved there - the new group is deleted when leaving visual mode or leaving buffer Making most of the autocommands local to the buffer reduces unnecessary checks and improves the overall efficiency of hint display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 changes optimize showing hint text in visual mode by avoiding hooking "CursorMoved" events unless absolutely needed and refactoring code to not require as many checks.
This should help with issue #711 (although more changes are needed to fully fix it).