fix tool_calls serialization for Scaleway Mistral (OpenAI Chat Completions) #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silenceforest
changed the title
Waitzz
reviewed
Dec 29, 2025
lua/avante/providers/openai.lua
Outdated
| function M.is_openrouter(url) return url:match("^https://openrouter%.ai/") end | ||
|
|
||
| function M.is_mistral(url) return url:match("^https://api%.mistral%.ai/") end | ||
| function M.is_mistral(url) return url:match("^https://api%.mistral%.ai/") or url:match("^https://api%.scaleway%.ai/") end |
Collaborator
There was a problem hiding this comment.
@silenceforest The behavior does not match the function name. Can it be optimized?
There was a problem hiding this comment.
sure, is the new name (is_mistral_like) better?
Collaborator
There was a problem hiding this comment.
Can you create a new function such as is_scaleway? And separate the processing of mistral and scaleway instead of sharing
There was a problem hiding this comment.
Implemented: added M.is_scaleway, keep M.is_mistral separate, and adjusted the tool-acknowledgement/streaming logic so Scaleway and Mistral each follow their own flow.
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.