feat!: use vim.ui.select for AvanteSwitchProvider #2935
+15
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim.ui.input is less practical then vim.ui.select which shows all models without having to trigger completion.

Also vim.ui.select can be overriden by pickers like snack or fzf-lua (https://github.com/ibhagwan/fzf-lua#neovim-api) eg:
Now this can be seen as a breaking change because:
AvanteSwitchProvider MODELis not accepted anymoreIn my first attempt I had
AvanteSwitchProvider PREFIXfilter the models before showing them to the user.If you agree with my change, let me know how you want to deal with the "breaking" behavior ?
:lua require("avante.api").switch_provider("mistral")instead ?AvanteSwitchProvider MODELdoes switch provider bypassing vim.ui.select (and/or MODEL acts as a filter)AvanteSwitchProviderand introduceAvanteSelectProviderinstead ? since it's annoying to keep both we deprecateAvanteSwitchProvider?Worst case I can keep this change in my own init.lua but as I found this version more helpful than avante's default I prefer to upstream.