Improve environment variable handling for ACP agents #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass through all environment variables by default * Allow environment variables to be overridden or entirely removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the default behavior when using gemini-cli in ACP mode when using the oauth-personal authentication mode. Without this fix, the ACP session silently fails on startup. I found that gemini-cli requires the
HOMEenvironment variable to be set, but the current behavior of avante is to strip away all environment variables exceptPATH.I couldn't find any documented justification for the current behavior. Given that people typically run gemini-cli without scrubbing away their environment variables, I couldn't see a real security argument for stripping the environment down either.