fix(copilot): refresh token before sending the request #791
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brewinski
force-pushed
the
fix/copilot-token-expired
branch
2 times, most recently
from
0f35b3b
to
87e3841
Compare
aarnphm
changed the title
Thanks for taking the time to review @aarnphm. I've responded and look forward to any advice you have for improving this PR. |
aarnphm
reviewed
Nov 5, 2024
|
@aarnphm I've updated the response status logic. Thanks again for spending your time looking into this, please let me know if you need any further changes or updates from me. |
…red token errors. fix(copilot) update and save copilot token when the response is 200 fix(copilot) update refresh token on editor startup
brewinski
force-pushed
the
fix/copilot-token-expired
branch
from
dd09825
to
9d8b645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was occasionally encountering 401 error responses when using the Copilot provider. Upon investigation, I discovered that the chat/complete request was being sent before the token could be refreshed.
To address this issue, I have modified the token refresh call to be synchronous. Additionally, I have used
vim.scheduleto refresh the token on startup.