Skip to content

chore: remove redundant word in comment #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

gcmutator
Copy link
Contributor

@gcmutator gcmutator commented Jun 6, 2025

Description

remove redundant word in comment

Fixes #0000

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Jun 6, 2025

Visit the preview URL for this PR (updated for commit d8aa954):

https://yew-rs-api--pr3868-master-uiucgsi5.web.app

(expires Fri, 13 Jun 2025 07:20:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Jun 6, 2025

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.321 100.321 0 0.000%
boids 169.069 169.069 0 0.000%
communication_child_to_parent 92.392 92.392 0 0.000%
communication_grandchild_with_grandparent 103.563 103.563 0 0.000%
communication_grandparent_to_grandchild 98.574 98.574 0 0.000%
communication_parent_to_child 88.274 88.274 0 0.000%
contexts 104.667 104.667 0 0.000%
counter 84.975 84.975 0 0.000%
counter_functional 85.393 85.393 0 0.000%
dyn_create_destroy_apps 87.997 87.997 0 0.000%
file_upload 99.166 99.166 0 0.000%
function_memory_game 171.076 171.076 0 0.000%
function_router 339.198 339.198 0 0.000%
function_todomvc 164.261 164.261 0 0.000%
futures 237.145 237.145 0 0.000%
game_of_life 105.199 105.199 0 0.000%
immutable 195.465 195.465 0 0.000%
inner_html 80.633 80.633 0 0.000%
js_callback 108.144 108.144 0 0.000%
keyed_list 196.342 196.342 0 0.000%
mount_point 83.947 83.947 0 0.000%
nested_list 113.315 113.315 0 0.000%
node_refs 91.276 91.276 0 0.000%
password_strength 1786.204 1786.204 0 0.000%
portals 93.223 93.223 0 0.000%
router 307.895 307.895 0 0.000%
suspense 112.146 112.146 0 0.000%
timer 89.071 89.071 0 0.000%
timer_functional 95.285 95.285 0 0.000%
todomvc 144.242 144.242 0 0.000%
two_apps 86.343 86.343 0 0.000%
web_worker_fib 135.435 135.435 0 0.000%
web_worker_prime 186.037 186.037 0 0.000%
webgl 83.557 83.557 0 0.000%

✅ None of the examples has changed their size significantly.

@Madoshakalaka
Copy link
Member

this looks good. the CI failure is not related

@Madoshakalaka Madoshakalaka merged commit 4d08a03 into yewstack:master Jun 17, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants