Skip to content

chore: fix some minor issues in the comments #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

rustfix
Copy link
Contributor

@rustfix rustfix commented Jul 6, 2025

Description

fix some minor issues in the comments

Fixes #0000

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Jul 6, 2025

Visit the preview URL for this PR (updated for commit a687fe3):

https://yew-rs-api--pr3872-master-adrnej55.web.app

(expires Sun, 13 Jul 2025 05:53:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Jul 6, 2025

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.462 ns      │ 3.709 ns      │ 2.464 ns      │ 2.493 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.435 ns      │ 3.302 ns      │ 2.439 ns      │ 2.453 ns      │ 100     │ 1000000000

Copy link

github-actions bot commented Jul 6, 2025

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.832 292.554 291.116 0.534
Hello World 10 483.291 501.212 488.880 6.433
Function Router 10 1595.194 1619.743 1602.358 7.677
Concurrent Task 10 1005.174 1006.290 1005.747 0.395
Many Providers 10 1074.520 1112.175 1088.331 13.119

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.074 291.404 290.949 0.344
Hello World 10 480.365 500.535 485.958 6.489
Function Router 10 1613.299 1633.573 1624.534 6.075
Concurrent Task 10 1005.228 1006.387 1005.910 0.447
Many Providers 10 1088.463 1151.685 1119.404 15.427

Copy link

github-actions bot commented Jul 6, 2025

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.035 100.035 0 0.000%
boids 168.678 168.678 0 0.000%
communication_child_to_parent 92.284 92.284 0 0.000%
communication_grandchild_with_grandparent 103.469 103.469 0 0.000%
communication_grandparent_to_grandchild 98.463 98.463 0 0.000%
communication_parent_to_child 88.154 88.154 0 0.000%
contexts 104.540 104.540 0 0.000%
counter 84.862 84.862 0 0.000%
counter_functional 85.278 85.278 0 0.000%
dyn_create_destroy_apps 87.862 87.862 0 0.000%
file_upload 99.041 99.041 0 0.000%
function_memory_game 170.662 170.662 0 0.000%
function_router 338.928 338.928 0 0.000%
function_todomvc 163.931 163.931 0 0.000%
futures 237.058 237.058 0 0.000%
game_of_life 104.953 104.953 0 0.000%
immutable 195.368 195.368 0 0.000%
inner_html 80.531 80.531 0 0.000%
js_callback 108.008 108.008 0 0.000%
keyed_list 196.019 196.019 0 0.000%
mount_point 83.837 83.837 0 0.000%
nested_list 113.167 113.167 0 0.000%
node_refs 91.173 91.173 0 0.000%
password_strength 1786.256 1786.256 0 0.000%
portals 93.114 93.114 0 0.000%
router 307.761 307.761 0 0.000%
suspense 112.002 112.002 0 0.000%
timer 88.892 88.892 0 0.000%
timer_functional 95.132 95.132 0 0.000%
todomvc 143.937 143.937 0 0.000%
two_apps 86.224 86.224 0 0.000%
web_worker_fib 135.221 135.221 0 0.000%
web_worker_prime 185.609 185.609 0 0.000%
webgl 83.454 83.454 0 0.000%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka merged commit 8945ab7 into yewstack:master Jul 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants