fix: avoid encoding '/' in wildcard route segments#4056
Open
Madoshakalaka wants to merge 1 commit intomasterfrom
Open
fix: avoid encoding '/' in wildcard route segments#4056Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
The Routable derive macro applied encode_for_url uniformly to all route parameters, including wildcard (*path) segments. This caused '/' within wildcard values to be encoded as '%2F', producing broken URLs like '/file/docs%2Fguides%2Fgetting-started.md' instead of '/file/docs/guides/getting-started.md'. The fix introduces encode_path_for_url which splits on '/', encodes each segment individually, then rejoins with '/'. The macro now tracks which fields originate from wildcard patterns and uses the path-aware encoder for those fields while keeping the existing encoder for named (:param) segments. Closes #3514
|
Visit the preview URL for this PR (updated for commit a09ee64): https://yew-rs-api--pr4056-fix-router-wildcard-vdjb461i.web.app (expires Sun, 15 Mar 2026 06:52:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Madoshakalaka
added
A-yew-router
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3514
Checklist