-
Notifications
You must be signed in to change notification settings - Fork 292
[revised] Add -uid and -uid flags to drop permissions #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1c813d7
Add -uid and -uid flags to drop permissions
70b9274
Merge branch 'master' of https://github.com/tsuraan/yggdrasil-go into…
Arceliar b299d7e
move setuid/setgid into separate functions in platform-dependent files
Arceliar 334a7ac
rename to setids_unix.go and adjust build directives accordingly
Arceliar d21a0a7
fix build directive
Arceliar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// +build !aix,!darwin,!dragonfly,!freebsd,!linux,!netbsd,!openbsd,!solaris | ||
|
||
package main | ||
|
||
import "errors" | ||
|
||
func setuid(uid int) error { | ||
return errors.New("setting uid not supported on this platform") | ||
} | ||
|
||
func setgid(gid int) error { | ||
return errors.New("setting gid not supported on this platform") | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// +build aix darwin dragonfly freebsd linux netbsd openbsd solaris | ||
|
||
package main | ||
|
||
import "syscall" | ||
|
||
func setuid(uid int) error { | ||
return syscall.Setuid(uid) | ||
} | ||
|
||
func setgid(gid int) error { | ||
return syscall.Setgid(gid) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of simply returning, you likely want to abort() here.
Not being able to change gid/uid (or egid/euid) is not a failure you should ignore and then simply continue running.