Make it possible to override the default AdminListen option at compile time #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #816
The intent here is to make it possible for package maintainers to set the default admin listen value to something appropriate for the distribution. At the moment, the existing default values are unchanged, but I'm considering "none" for all platforms (just to be consistent). I'm not sure I like this approach, but if we go this route, then it probably makes sense to make some of the other default configurable at compile time (and clean up this code, there's probably a better way to do it).
Usage:
./build -l '-X github.com/yggdrasil-network/yggdrasil-go/src/defaults.adminListen=whatever'