Add missing PacketBuffer DecRef() calls to prevent crashes #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a critical memory management bug in the gVisor netstack integration that caused immediate application crashes due to incorrect PacketBuffer reference counting. Missing DecRef() calls were added in key packet processing paths to prevent reference count panics (Incrementing/Decrementing non-positive ref count) and SIGABRT crashes.
How to reproduce:
Run nmap port scanner against yggstack node. Result - 100% app crush.
Crash Evidence
From logcat analysis:
panic: Decrementing non-positive ref count 0x4000348c60panic: Incrementing non-positive count 0x400007e7c0runtime.DefaultDispatchthreads during buffer operationstombstone_23andtombstone_24Comment
We got this behavior on yggstack-android app (https://github.com/DrewCyber/yggstack-android) v0.1.22.
After this fix app works 100% correctly (v.0.1.23).