Skip to content

Fix rubocop offenses #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 2, 2025
Merged

Fix rubocop offenses #40

merged 14 commits into from
Jan 2, 2025

Conversation

yhirano55
Copy link
Owner

This pull request includes various changes to improve code quality, fix RuboCop offenses, and enhance the trace_location gem. The most important changes include updating the RuboCop configuration, modifying error handling, and improving test descriptions and structure.

RuboCop Configuration Updates:

  • Removed exclusions for several RuboCop cops in the .rubocop_todo.yml file. This change ensures that the codebase adheres to more stringent linting rules.

Code Quality Improvements:

  • Added # frozen_string_literal: true to several files to optimize string handling and improve performance. [1] [2]
  • Replaced $stderr.puts with warn for better error handling and consistency in lib/trace_location.rb.
  • Updated eval usage to include a RuboCop directive to disable the security warning in lib/trace_location/cli.rb.

Testing Enhancements:

  • Improved test descriptions and structure in spec/trace_location_spec.rb by using described_class and adding context blocks for better readability and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Documentation and Changelog:

  • Updated the CHANGELOG.md to include a note about fixing RuboCop offenses.
  • Improved the gem description formatting in trace_location.gemspec for better readability.

These changes collectively enhance the code quality, maintainability, and performance of the trace_location gem.

@yhirano55 yhirano55 marked this pull request as ready for review January 2, 2025 01:17
@yhirano55 yhirano55 merged commit 920f635 into main Jan 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant