Feature/multipart headers #2152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwach
commented
Jun 6, 2025
kwach
commented
- feature: additional field: header - providing access to headers per form-data part
- UT test provided
Adds a `headers` field to the `MultipartFormData` struct. Populates this field by parsing headers from the multipart form data. This allows access to specific headers associated with each form data part.
Verifies the correct retrieval of headers from multipart form data file parts. Ensures that custom and content-related headers are accessible and parsed as expected.
Uses `gtest_discover_tests` to automatically find and run tests, simplifying test maintenance and improving discoverability.
yhirose
reviewed
Jun 6, 2025
| @@ -29,6 +29,7 @@ find_package(CURL REQUIRED) | |||
| add_executable(httplib-test test.cc include_httplib.cc $<$<BOOL:${WIN32}>:include_windows_h.cc>) | |||
| target_compile_options(httplib-test PRIVATE "$<$<CXX_COMPILER_ID:MSVC>:/utf-8;/bigobj>") | |||
| target_link_libraries(httplib-test PRIVATE httplib GTest::gtest_main CURL::libcurl) | |||
| include(GoogleTest) | |||
There was a problem hiding this comment.
@sum01 @jimmy-park is this change necessary?
There was a problem hiding this comment.
This line is redundant because the GoogleTest module is already included in find_package(GTest).
There was a problem hiding this comment.
@kwach could you please remove the line?
yhirose
reviewed
Jun 6, 2025
| @@ -5045,6 +5046,14 @@ class MultipartFormDataParser { | |||
| return false; | |||
| } | |||
|
|
|||
| // split header string by ':' and emplace space trimmed into headers map | |||
There was a problem hiding this comment.
You don't have to parse the header text yourself. You can replace the code from line no 5043 through 5047 with the following code, so that you can avoid the extra parsing.
if (!parse_header(
header.data(), header.data() + header.size(),
[&](const std::string &key, const std::string &val) {
file_.headers.emplace(key, val);
})) {
is_valid_ = false;
return false;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.