add figure captioning support for shiny.tag/shiny.tag.list objects #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
htmltools-figures
branch
from
65ee249 to
cc9b378
Compare
Contributor
Author
|
@yihui is this something you might consider merging? Would love to know your thoughts on it. |
yihui
reviewed
Apr 12, 2019
Owner
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Sorry for the late response. Since we are going to meet at the unconference, let's talk about it there (be sure to remind me if I forget).
cpsievert
force-pushed
the
htmltools-figures
branch
from
cc9b378 to
2631a4d
Compare
cpsievert
force-pushed
the
htmltools-figures
branch
from
2631a4d to
8def7bb
Compare
cpsievert
force-pushed
the
htmltools-figures
branch
from
8def7bb to
d5996a8
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rstudio/bookdown#74 (comment)