add logo #2370
Open
add logo #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yihui
reviewed
Oct 31, 2024
Owner
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Thank you! I'm okay with displaying the hex logo in README (even though I'm not really a hex logo person), but I prefer not shipping the png file in the package. Normally I try not to put binary files under version control, and a 236Kb image also appears too big to me. You can use a jsdelivr URL, e.g., https://cdn.jsdelivr.net/gh/rstudio/hex-stickers/SVG/knitr.svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the knitr logo and since the image is already in the 'central' CC0 repo of high quality logos I've added it to
man/figuresand to the readme. Hope this is OK