Skip to content

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jul 18, 2024

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
image
  • Error code showed
  • Showed functions arguments if they are

@xepozz xepozz requested a review from a team July 18, 2024 09:33
@xepozz xepozz added the status:code review The pull request needs review. label Jul 18, 2024
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 👍 Please add a line to CHANGELOG and merge.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add line to changelog

@samdark
Copy link
Member

samdark commented Dec 16, 2024

@vjik, @xepozz what's left in this pull request to be merged?

@vjik
Copy link
Member

vjik commented Dec 16, 2024

@vjik, @xepozz what's left in this pull request to be merged?

Seems, only this conversation: #125 (comment)

Co-authored-by: Sergei Predvoditelev <[email protected]>
@samdark samdark requested a review from vjik December 21, 2024 20:01
@samdark
Copy link
Member

samdark commented Dec 21, 2024

@vjik no unresolved issues left. Merging?

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (46b059d) to head (61ef967).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Renderer/HtmlRenderer.php 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     77.15%   77.43%   +0.27%     
- Complexity      180      184       +4     
============================================
  Files            14       14              
  Lines           569      576       +7     
============================================
+ Hits            439      446       +7     
  Misses          130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 16a53fd into master Dec 24, 2024
22 of 23 checks passed
@vjik vjik deleted the enhance branch December 24, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants