Introduce UserException attribute
#153
Conversation
vjik
commented
Aug 17, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Co-authored-by: Aleksei Gagarin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
=========================================
Coverage ? 81.06%
Complexity ? 215
=========================================
Files ? 20
Lines ? 692
Branches ? 0
=========================================
Hits ? 561
Misses ? 131
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the UserException as an attribute that can be used to mark exceptions as user-facing, expanding its functionality beyond just being an exception class. The change allows any exception class to be annotated with #[UserException] to indicate its messages are safe to display to end users.
- Added
UserException::is()static method to check if an exception is user-facing - Converted
UserExceptionto also function as a PHP attribute - Updated templates to use the new
is()method instead of instanceof checks
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Exception/UserException.php | Enhanced to work as both exception class and attribute, added static is() method |
| templates/production.php | Updated to use UserException::is() instead of instanceof check |
| tests/Exception/UserException/UserExceptionTest.php | Added comprehensive tests for the new functionality |
| tests/Exception/UserException/NotFoundException.php | Created test exception class using the new attribute |
| tests/Factory/ThrowableResponseFactoryTest.php | Code formatting cleanup (method chaining) |
| CHANGELOG.md | Added changelog entry for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Alexander Makarov <[email protected]>
| return true; | ||
| } | ||
|
|
||
| $attributes = (new ReflectionClass($throwable))->getAttributes(self::class); |
There was a problem hiding this comment.
Can caching affect performance? e.g long running apps
There was a problem hiding this comment.
I think it doesn't make sense in the case of exception handling.
4 participants
