Skip to content

Minor fixes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Minor fixes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb90ef2
Minor fixes
samdark Jun 3, 2025
c53c6c7
fix
vjik Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HttpCache/CacheControlProvider/CacheControlProviderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Psr\Http\Message\ServerRequestInterface;

/**
* Interface for `Cache-Control` header value providers. Given a request it generates a header value.
* Interface for `Cache-Control` header value providers. Given a request, it generates a header value.
*
* @link https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cache-Control
*/
Expand Down
2 changes: 0 additions & 2 deletions src/TagRequest/TagProvider/PredefinedTagProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
use IteratorIterator;
use OutOfBoundsException;

use Yiisoft\HttpMiddleware\TagRequest\TagProvider\TagProviderInterface;

use function is_array;

/**
Expand Down
2 changes: 0 additions & 2 deletions src/TagRequest/TagProvider/PrefixedTagProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

namespace Yiisoft\HttpMiddleware\TagRequest\TagProvider;

use Yiisoft\HttpMiddleware\TagRequest\TagProvider\TagProviderInterface;

/**
* A tag provider that prefixes the result of a decorated tag provider with a specified string.
*/
Expand Down
2 changes: 0 additions & 2 deletions src/TagRequest/TagProvider/TimeBasedTagProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

namespace Yiisoft\HttpMiddleware\TagRequest\TagProvider;

use Yiisoft\HttpMiddleware\TagRequest\TagProvider\TagProviderInterface;

use function uniqid;

/**
Expand Down
1 change: 0 additions & 1 deletion tests/HttpCache/ETagHeaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
use Yiisoft\HttpMiddleware\HttpCache\ETagHeader;

use function PHPUnit\Framework\assertSame;
use function PHPUnit\Framework\assertTrue;

final class ETagHeaderTest extends TestCase
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Support/StreamStub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function close(): void
throw new LogicException('Not implemented.');
}

public function detach()
public function detach(): void
{
throw new LogicException('Not implemented.');
}
Expand Down Expand Up @@ -86,7 +86,7 @@ public function getContents(): string
throw new LogicException('Not implemented.');
}

public function getMetadata(?string $key = null)
public function getMetadata(?string $key = null): void
{
throw new LogicException('Not implemented.');
}
Expand Down