Skip to content

PHP 8.4 support, fix psalm notices #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025
Merged

Conversation

batyrmastyr
Copy link
Contributor

@batyrmastyr batyrmastyr commented Jul 2, 2025

Q A
Is bugfix? ✔️support for DNF types, PHP 8.4 deprecations
New feature?
Breaks BC?
Fixed issues

Fixed PHP 8.4 deprecation warnings and psalm tests.

Updating CI to check PHP 8.4, fixing backward compatibility test - in another PR.

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.72%. Comparing base (7b47b39) to head (b72e905).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/ClassConfigFactory.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
- Coverage     96.62%   95.72%   -0.90%     
- Complexity       99      101       +2     
============================================
  Files            10       10              
  Lines           296      304       +8     
============================================
+ Hits            286      291       +5     
- Misses           10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add all supported PHP versions to CI
  • Change PHP constraint in composer.json to 8.0 - 8.4

@batyrmastyr batyrmastyr force-pushed the php84 branch 3 times, most recently from 8f4c23c to 3a80bcb Compare July 2, 2025 14:54
@vjik vjik added the status:code review The pull request needs review. label Jul 2, 2025
@vjik vjik requested a review from a team July 2, 2025 15:03
@vjik vjik requested a review from Tigrov July 7, 2025 18:51
@vjik vjik merged commit 1726e86 into yiisoft:master Jul 7, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants