Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pcntl_signal_dispatch after job finish for php extension #485

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dimanzver
Copy link

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues add pcntl_signal_dispatch after job finish for php extension

@what-the-diff
Copy link

what-the-diff bot commented Apr 27, 2023

PR Summary

  • Package Name Change
    Changed the package name from yiisoft/yii2-queue to dimanzver/yii2-queue to use a different source for the queue component

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use-case?

composer.json Outdated Show resolved Hide resolved
@dimanzver
Copy link
Author

Look now - I reworked logic

@samdark samdark requested a review from s1lver June 19, 2023 12:00
@s1lver
Copy link
Member

s1lver commented Jun 19, 2023

No need to change the package name yiisoft/yii2-queue => dimanzver/yii2-queue in composer.json. Please roll back this change

@s1lver
Copy link
Member

s1lver commented Jul 1, 2024

@dimanzver i still don’t understand what problem is being solved. can you describe your problem in more detail? It would be better to include tests

@dimanzver
Copy link
Author

@s1lver If queue worker launched in kubernetes, on deploy kubernetes sends a SIGTERM signal to the worker process in old deployment. If worker didn`t processed this signal and still works, kubernetes sends a SIGKILL signal after 30 seconds (may be changed in terminationGracePeriodSeconds). And big job will be killed in the middle of the road.
This fix stops worker after next message after SIGTERM signal will be received or current job will be finished,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants