-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pcntl_signal_dispatch after job finish for php extension #485
base: master
Are you sure you want to change the base?
Conversation
dimanzver
commented
Apr 27, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | add pcntl_signal_dispatch after job finish for php extension |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use-case?
Look now - I reworked logic |
No need to change the package name |
@dimanzver i still don’t understand what problem is being solved. can you describe your problem in more detail? It would be better to include tests |
@s1lver If queue worker launched in kubernetes, on deploy kubernetes sends a SIGTERM signal to the worker process in old deployment. If worker didn`t processed this signal and still works, kubernetes sends a SIGKILL signal after 30 seconds (may be changed in |