Fix mix to accept old or new nil values
#780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/phlex/helpers.rb
Outdated
Comment on lines
29
to
30
| else | ||
| new | ||
| new.nil? ? old : new |
There was a problem hiding this comment.
What do you think about following the pattern matching style with something like:
case [old, new]
# ...
in [_, nil]
old
else
new
endThere was a problem hiding this comment.
the _ was exactly what I was looking for. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779, but
I don't think it's all the way there because it only handles the. I don't know the reasons the code changed for[String, nil]combomixso much in 0f8d8cb#diff-1379affdd94a5363d3331840af91bc6171dac9338b2f6bd886a0636ac6258a38, so this is more a starting point.Update: in the second commit I made it work for the other types, but I'm sure there are other approaches to consider.