Non-visible child products in bundle cause Fatal Exception

yireo · Jun 20, 2023 · 025412f · 025412f
1 parent fad2369
commit 025412f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.4.1] - 20 June 2023
+### Fixed
+- Non-visible child products in bundle cause Fatal Exception
+
 ## [3.4.0] - 19 June 2023
 ### Added
 - Option to delay loading GTM until user interaction is triggered

diff --git a/DataLayer/Mapper/CartItemDataMapper.php b/DataLayer/Mapper/CartItemDataMapper.php
@@ -38,14 +38,19 @@ public function __construct(
     /**
      * @param CartItemInterface $cartItem
      * @return array
-     * @throws NoSuchEntityException
      * @throws LocalizedException
      */
     public function mapByCartItem(CartItemInterface $cartItem): array
     {
-        $product = $this->productRepository->get($cartItem->getSku());
-        $cartItemData = $this->productDataMapper->mapByProduct($product);
+        try {
+            $product = $this->productRepository->get($cartItem->getSku());
+            $cartItemData = $this->productDataMapper->mapByProduct($product);
+        } catch (NoSuchEntityException $e) {
+            $cartItemData = [];
+        }
+
         return array_merge($cartItemData, [
+            'item_sku' => $cartItem->getSku(),
             'item_name' => $cartItem->getName(),
             'order_item_id' => $cartItem->getItemId(),
             'quantity' => (float) $cartItem->getQty(),

diff --git a/DataLayer/Tag/Cart/CartItems.php b/DataLayer/Tag/Cart/CartItems.php
@@ -40,7 +40,6 @@ public function get(): array
 
         $cartItemsData = [];
         foreach ($cartItems as $cartItem) {
-            $cartItem->getProduct();
             $cartItemData = $this->cartItemDataMapper->mapByCartItem($cartItem);
             $cartItemsData[] = $cartItemData;
         }

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yireo/magento2-googletagmanager2",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "license": "OSL-3.0",
   "type": "magento2-module",
   "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",