Emergency fix for number_format (3 args instead of 4) under PHP 7.4

yireo · Jun 16, 2023 · 32dd608 · 32dd608
1 parent cea3c45
commit 32dd608
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.3.3] - 16 June 2023
+### Fixed
+- Emergency fix for `number_format` (3 args instead of 4) under PHP 7.4
+
 ## [3.3.2] - 16 June 2023
 ### Fixed
 - Guarantee that cart value is always returned with 4 decimals

diff --git a/DataLayer/Tag/Cart/CartValue.php b/DataLayer/Tag/Cart/CartValue.php
@@ -27,6 +27,6 @@ public function __construct(
      */
     public function get(): string
     {
-        return number_format((float)$this->cartModel->getQuote()->getBaseGrandTotal(), 4, '.');
+        return number_format((float)$this->cartModel->getQuote()->getBaseGrandTotal(), 4);
     }
 }
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yireo/magento2-googletagmanager2",
-  "version": "3.3.2",
+  "version": "3.3.3",
   "license": "OSL-3.0",
   "type": "magento2-module",
   "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",