Fix issue with uninitialized eventData caused by 3.4.4

yireo · Jun 27, 2023 · beefa9d · beefa9d
1 parent d1cd0fb
commit beefa9d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.4.5] - 27 June 2023
+### Fixed
+- Fix issue with uninitialized `eventData` caused by 3.4.4
+
 ## [3.4.4] - 26 June 2023
 ### Fixed
 - Fixed stepNavigator issue in non-default checkout

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yireo/magento2-googletagmanager2",
-  "version": "3.4.4",
+  "version": "3.4.5",
   "license": "OSL-3.0",
   "type": "magento2-module",
   "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",

diff --git a/view/frontend/web/js/mixins/step-navigator-mixin.js b/view/frontend/web/js/mixins/step-navigator-mixin.js
@@ -12,6 +12,8 @@ define([
 
         stepNavigator.steps.subscribe(function (steps) {
             const firstStep = steps[0];
+            const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT;
+
             if (firstStep === undefined || firstStep == null || firstStep.length <= 0) {
                 logger('Error: No steps detected. Triggering event anyway :o')
                 pusher(eventData, 'push (page event "begin_checkout") [step-navigator-mixin.js]');
@@ -22,8 +24,6 @@ define([
                 return;
             }
 
-            const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT;
-
             if (eventData === null || eventData === undefined) {
                 logger('skipped "begin_checkout" event because data is empty')
                 return;