Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloned or otherwise malformed products can break the builder #109

Open
froboy opened this issue Mar 16, 2022 · 0 comments · May be fixed by #110
Open

Cloned or otherwise malformed products can break the builder #109

froboy opened this issue Mar 16, 2022 · 0 comments · May be fixed by #110

Comments

@froboy
Copy link
Collaborator

froboy commented Mar 16, 2022

Cloning a product could result in a malformed product, which causes the membership-builder to throw:

Error: Call to a member function uuid() on null in Drupal\openy_memberships\Controller\OpenyMemberships->getProductsInBranch() (line 354 of /var/www/html/yhbb/docroot/modules/contrib/openy_memberships/src/Controller/OpenyMemberships.php)

A simple check should cause those broken products to not break everything.
@froboy froboy linked a pull request Mar 16, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure variant exists froboy/openy_memberships
1 participant
@froboy