Redid the Action Popup #1525
Open
Redid the Action Popup #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martholomew
commented
Oct 25, 2024
martholomew
commented
- Changed the layout in favor of a more modern, material layout.
- Added a dynamic tooltip indicating how to scan.
- Redid some logic in the On/Off switch so that it updates when profiles are switched (there remains an edge case when the settings page is focused where it exhibits strange behavior).
…gic in action-popup-main.js
jamesmaa
reviewed
Oct 25, 2024
ext/action-popup.html
Outdated
| <h2>Profile</h2> | ||
| </div> | ||
| <div class="action-item-right"> | ||
| <select class="profile-select" id="profile-select"> |
There was a problem hiding this comment.
This dropdown can only handle about 8 character strings before it cuts out and looks weird
|
Does this take into account the mobile version of the popup? It looks like youve just ripped out all of that. |
|
I like the colors you went with, with the gradient showing only when it's on. |
|
|
|
Theres a function somewhere that sets that text for the correct OS since it's always different. Can just borrow that. |
… messages; still missing mobile version
Kuuuube
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.