Open
Conversation
Also increase JUnit 4 version to avoid CVE flagging
fanweixiao
requested changes
Jun 2, 2022
Member
fanweixiao
left a comment
fanweixiao
left a comment
There was a problem hiding this comment.
Can you add tests for newly added ctor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating hashes that are separated by 100 the hash strings are very similar. This is unavoidable with this implementation and perhaps not a huge deal, but maybe it would be best if the periodicity were a number that is not so "tidy". This PR adds the ability to construct the class with a user-specified hash mod base. I personally would use a similarly large prime number, like 97. The strings are very similar for every 97 ids, but this is probably less likely to be noticed.
Also increase JUnit 4 version to avoid CVE flagging